Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> 0.94 tests back in shape and some guidelines


Copy link to this message
-
Re: 0.94 tests back in shape and some guidelines
Interesting that the runs for 0.94 are good again up on Jenkins but running
them locally (@ r1426067) I get:

> $ mvn clean test -PrunAllTests -DskipITs -Djava.net.preferIPv4Stack=true
[...]

Results :
Failed tests:
testBasicRollingRestart(org.apache.hadoop.hbase.master.TestRollingRestart):
expected:<22> but was:<23>

testAcquireTaskAtStartup(org.apache.hadoop.hbase.regionserver.TestSplitLogWorker):
ctr=0, oldval=0, newval=1

Tests in error:

testDelayedDeleteOnFailure(org.apache.hadoop.hbase.master.TestDistributedLogSplitting):
test timed out after 25000 milliseconds
  test3686a(org.apache.hadoop.hbase.client.TestScannerTimeout): 11759ms
passed since the last invocation, timeout is currently set to 10000
  queueFailover(org.apache.hadoop.hbase.replication.TestReplication): test
timed out after 300000 milliseconds

queueFailover(org.apache.hadoop.hbase.replication.TestReplicationWithCompression):
test timed out after 300000 milliseconds

testRunThriftServer[9](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine):
test timed out after 60000 milliseconds

testShutdownFixupWhenDaughterHasSplit(org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster)

Tests run: 1220, Failures: 2, Errors: 6, Skipped: 13

Will start looking at some of these tomorrow.

On Tue, Dec 25, 2012 at 5:29 PM, Andrew Purtell <[EMAIL PROTECTED]> wrote:

> Thank you so much for doing this Lars.
>
> >  I will retroactively -1 the change and revert it, and then shame you
> again. :)
>
> +1
>
> On Tuesday, December 25, 2012, lars hofhansl wrote:
>
>> During the past few days I spend some time to bring the 0.94 test back
>> into shape.
>>
>> GC issues, bad backports, hanging tests, memory issues, you name it.
>> I do not want to ever have to do that again.
>>
>> The good news is: The 0.94 tests are back in shape now. Yeah!
>>
>> If you commit a patch it is your responsibility to make sure it passes
>> the test suite.
>> Either the tests should be fixed in a reasonable amount of time or the
>> commit should be reverted.
>> This is mainly for committers, contributors should also watch the test
>> runs for their patches.
>> No excuses. The tests are passing now.
>> I do not care whether a test passes locally, or whether it fails rarely,
>> or whether some tests failed previously, or whatever.
>>
>> Please, consider this a condition for me to continue as release manager
>> for 0.94.
>> (This is only for the 0.94 tests. I cannot speak for HadoopQA, or the
>> regular trunk test suite, although eventually I assume we want similar
>> guidelines there)
>>
>> I increased the retention time for past builds. I will find you :)
>> I will publicly shame you. I will retroactively -1 the change and revert
>> it, and then shame you again. :)
>>
>> Lastly, this is a function of the large amount of contributed patches. So
>> it is a good problem to have.
>> HBase it an actively maintained project and we certainly want to keep it
>> this way, just with an acknoledgement that keeping the test suite passing
>> is important.
>>
>> Thanks and Merry Christmas (to whoever celebrates that).
>>
>> -- Lars
>
>
>
> --
> Best regards,
>
>    - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
>
--
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)