Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request: HIVE-4597: Move Vector Expression and Vector Expression Evaluation Test Generation


Copy link to this message
-
Review Request: HIVE-4597: Move Vector Expression and Vector Expression Evaluation Test Generation
tony murphy 2013-05-23, 19:28

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11349/
-----------------------------------------------------------

Review request for hive, Jitendra Pandey, Eric Hanson, Sarvesh Sakalanaga, and Remus Rusanu.
Description
-------

Move Vector Expression and Vector Expression Evaluation Test Generation to \ql\src\gen\vectorization and update CodeGen to place generated files correctly into source tree. See lines 218 to 249 for changes.
This addresses bug HIVE-4597.
    https://issues.apache.org/jira/browse/HIVE-4597
Diffs
-----

  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/CodeGen.java PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/ColumnArithmeticColumn.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/ColumnArithmeticScalar.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/ColumnCompareScalar.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/ColumnUnaryMinus.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterColumnCompareColumn.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterColumnCompareScalar.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColumnCompareColumn.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/FilterStringColumnCompareScalar.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/ScalarArithmeticColumn.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestClass.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestCodeGen.java PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestColumnColumnFilterVectorExpressionEvaluation.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestColumnColumnOperationVectorExpressionEvaluation.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestColumnScalarFilterVectorExpressionEvaluation.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/TestColumnScalarOperationVectorExpressionEvaluation.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/VectorUDAFAvg.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/VectorUDAFCount.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/VectorUDAFMinMax.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/VectorUDAFSum.txt PRE-CREATION
  ql/src/gen/vectorization/org/apache/hadoop/hive/ql/exec/vector/expressions/gen/VectorUDAFVar.txt PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 3ef2aa8
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnArithmeticColumn.txt 0e56721
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnArithmeticScalar.txt 474a979
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnCompareScalar.txt dcf87b0
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnUnaryMinus.txt 9d16bdd
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterColumnCompareColumn.txt 8e3b717
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterColumnCompareScalar.txt 04bc69c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareColumn.txt 9309326
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareScalar.txt 30eddcf
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ScalarArithmeticColumn.txt 9899e7e
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestClass.txt c8de5de
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestCodeGen.java 34c093c
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestColumnColumnFilterVectorExpressionEvaluation.txt 2bb1aa3
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestColumnColumnOperationVectorExpressionEvaluation.txt 4ab3e76
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestColumnScalarFilterVectorExpressionEvaluation.txt 5b53d6a
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/TestColumnScalarOperationVectorExpressionEvaluation.txt e5f3f18
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFAvg.txt d85346d
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFCount.txt 54c80ec
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFMinMax.txt d00d9ae
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFSum.txt aaaa6ad
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFVar.txt daae57b

Diff: https://reviews.apache.org/r/11349/diff/
Testing

validated generated code goes to correct locations with default execution:
\ql\src\gen\vectorization> javac .\org\apache\hadoop\hive\ql\exec\vector\expressions\gen\*.java
\ql\src\gen\vectorization> java org.apache.hadoop.hive.ql.exec.vector.expressions.gen.CodeGen
Thanks,

tony murphy