Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Re: Review Request 14224: HIVE-5202


Copy link to this message
-
Re: Review Request 14224: HIVE-5202
Hari Sankar Sivarama Subr... 2013-09-21, 00:49

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14224/
-----------------------------------------------------------

(Updated Sept. 21, 2013, 12:49 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------

HIVE-5202
Bugs: HIVE-5202
    https://issues.apache.org/jira/browse/HIVE-5202
Repository: hive
Description
-------

The fix includes the changes to introduce:
1. SettableUnionObjectInspector support.
2. Include caching while ObjectInspectorConverters.getConvertedOI()is invoked by the clients.
3. ObjectInspectorUtils.hasAllFieldsSettable() which see if all the underlying objectinspectors within a datatype can be converted to its settableOI type.  
Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1524321
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 1524321
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/org/apache/hadoop/hive/serde2/CustomNonSettableUnionObjectInspector1.java PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/org/apache/hadoop/hive/serde2/CustomSerDe4.java PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/org/apache/hadoop/hive/serde2/CustomSerDe5.java PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/partition_wise_fileformat18.q PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/partition_wise_fileformat18.q.out PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java 1524321
  http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1524321
  http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SettableUnionObjectInspector.java PRE-CREATION
  http://svn.apache.org/repos/asf/hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardUnionObjectInspector.java 1524321

Diff: https://reviews.apache.org/r/14224/diff/
Testing
-------

Added unit test in partition_wise_fileformat18.q.
Ran unit tests  partition_wise_fileformat* locally.
Thanks,

Hari Sankar Sivarama Subramaniyan