Great question. I've been doing review of posted patches for a most of the features before merging. We also internally have a substantial smoke test suite that we run before doing merges. We're in the process of trying to clean it up and make it available externally so that others can use this as an additional check before merging. My thought would be that minor fixes that have gone through unit test + smoke test validation should be mergeable directly by committers. Larger commits should go through a review process. I haven't been perfect at this in the last little bit so thanks for the reminder.
thanks, Jacques On Wed, Jun 11, 2014 at 1:01 PM, Timothy Chen <[EMAIL PROTECTED]> wrote:
I was hoping to see the larger commits like view persistence, PStore go through reviewboard first as lots of times there isn't even a design discussion and just straight code that just goes into trunk.
I think to foster a better community outside of MapR, Drill should be more on the open about big changes and involve the community a bit more.
On Wed, Jun 11, 2014 at 2:38 PM, Jacques Nadeau <[EMAIL PROTECTED]> wrote:
Oh, it is the default value of sys.store.provider. But without setting the value, I get the following exception when starting drillbit with distributed mode.
Exception in thread "main" org.apache.drill.exec.exception.DrillbitStartupException: Failure while initializing values in Drillbit. at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:70) at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:61) at org.apache.drill.exec.server.Drillbit.main(Drillbit.java:83) Caused by: org.apache.drill.common.exceptions.ExecutionSetupException: A System Table provider was either not specified or could not be found or instantiated at org.apache.drill.exec.store.sys.PStoreRegistry.newPStoreProvider(PStoreRegistry.java:59) at org.apache.drill.exec.server.Drillbit.<init>(Drillbit.java:116) at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:68) ... 2 more Caused by: java.lang.NoSuchMethodException: org.apache.drill.exec.store.sys.local.LocalPStoreProvider.<init>(org.apache.drill.exec.store.sys.PStoreRegistry) at java.lang.Class.getConstructor0(Class.java:2810) at java.lang.Class.getConstructor(Class.java:1718) at org.apache.drill.exec.store.sys.PStoreRegistry.newPStoreProvider(PStoreRegistry.java:54) ... 4 more Exception in thread "ShutdownHook" java.lang.UnsupportedOperationException: Unknown handle type at org.apache.drill.exec.coord.zk.ZKClusterCoordinator.unregister(ZKClusterCoordinator.java:151) at org.apache.drill.exec.server.Drillbit.close(Drillbit.java:159) at org.apache.drill.exec.server.Drillbit$ShutdownThread.run(Drillbit.java:187)
On Wed, Jun 11, 2014 at 4:45 PM, Aditya <[EMAIL PROTECTED]> wrote:
Apache Lucene, Apache Solr and all other Apache Software Foundation project and their respective logos are trademarks of the Apache Software Foundation.
Elasticsearch, Kibana, Logstash, and Beats are trademarks of Elasticsearch BV, registered in the U.S. and in other countries. This site and Sematext Group is in no way affiliated with Elasticsearch BV.
Service operated by Sematext