Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-947 Introduce the concept of "sensitivity" input to all supported metadata structures


+
Abraham Elmahrek 2013-03-21, 00:32
Copy link to this message
-
Re: Review Request: SQOOP-947 Introduce the concept of "sensitivity" input to all supported metadata structures
Jarek Cecho 2013-03-23, 16:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10048/#review18317
-----------------------------------------------------------
Hi Abe,
thank you very much for working on this one. Changes looks good to me, I just have few minor comments:

1) Would you mind rebasing on current head of sqoop2 branch? I'm having compilation exception because of recent changes.
client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
<https://reviews.apache.org/r/10048/#comment38520>

    I can see the same if-else condition in every "displayInput$TYPE" method. What about refactoring the code a bit and putting the if-else logic into calling method displayForm()?

client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
<https://reviews.apache.org/r/10048/#comment38521>

    I can see the same if-else on multiple places. What about refactoring it to standalone method?
Jarcec

- Jarek Cecho
On March 21, 2013, 12:32 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10048/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 12:32 a.m.)
>
>
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
>
>
> Description
> -------
>
> commit 64f2ddbf5654ea8bbcc47dc7cc4cabd6168c4fad
> Author: Abraham Elmahrek <[EMAIL PROTECTED]>
> Date:   Wed Mar 20 12:15:59 2013 -0700
>
>     SQOOP-947 Introduce the concept of "sensitivity" input to all supported metadata structures
>
> :100644 100644 8b40a54... 523f498... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 e88216d... 80b10c8... M common/src/main/java/org/apache/sqoop/model/FormUtils.java
> :100644 100644 77598a8... 12705a6... M common/src/main/java/org/apache/sqoop/model/MEnumInput.java
> :100644 100644 96397e8... ea3d753... M common/src/main/java/org/apache/sqoop/model/MInput.java
> :100644 100644 d281d7e... d23ac31... M common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
> :100644 100644 b458022... 704c1f8... M common/src/main/java/org/apache/sqoop/model/MMapInput.java
> :100644 100644 e96ec92... 16da76d... M common/src/main/java/org/apache/sqoop/model/MStringInput.java
> :100644 100644 85c65de... 08dfa7b... M common/src/test/java/org/apache/sqoop/model/TestFormUtils.java
> :100644 100644 1cde5cf... 4ea42b1... M common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 a99b7dc... c3469ff... M common/src/test/java/org/apache/sqoop/model/TestMConnection.java
> :100644 100644 1d86c13... edaedb1... M common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
> :100644 100644 b7b1356... 0bd55d9... M common/src/test/java/org/apache/sqoop/model/TestMForm.java
> :100644 100644 5f599eb... bd21fcb... M common/src/test/java/org/apache/sqoop/model/TestMFormList.java
> :100644 100644 042158a... 1f38e6d... M common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java
> :100644 100644 772f230... 1587147... M common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
> :100644 100644 fa6b9ad... f336bab... M common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java
> :100644 100644 2ba9709... 7822ba5... M common/src/test/java/org/apache/sqoop/model/TestMStringInput.java
> :100644 100644 8d07521... 3fd5a95... M common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java
> :100644 100644 8af86b7... 486635d... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
>
>
> This addresses bug SQOOP-947.
>     https://issues.apache.org/jira/browse/SQOOP-947
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java cc80df108e2b2944fc31c9fba17b3639df663eec
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 0609ae103fd3b7bcd9b0a3d1a9063ccf542d9b5c
+
Abraham Elmahrek 2013-03-25, 20:10
+
Jarek Cecho 2013-03-25, 20:33