Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: In-process Hive CLI driver does not work

David Robson 2012-09-18, 06:30
Copy link to this message
Re: Review Request: In-process Hive CLI driver does not work

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2012, 6:02 a.m.)
Review request for Sqoop.

Remove fragment identified by Jarcec.

Throw the exception from the old namespace to support anyone checking the old exception. Also update HiveImport to check the new namespace.
This addresses bug SQOOP-607.
Diffs (updated)

  src/java/org/apache/sqoop/util/SubprocessSecurityManager.java 4951627

Diff: https://reviews.apache.org/r/7143/diff/

Created a mock Hive CLI that calls System.exit(0). Can see it now works.
Was trying to create an automated test but the problem was once I created the mock class it was used for the other tests as well instead of the shell script.
The easiest way I can see to create a unit test would be to allow the Hive CLI class to be specified as a parameter - that way it could be overridden in a unit test to a mock class.
Was also thinking about loading the class at runtime but this seemed like a bit of work for a small bug fix.

David Robson

Jarek Cecho 2012-09-19, 08:49
Jarek Cecho 2012-09-18, 06:49
David Robson 2012-09-18, 23:02
Jarek Cecho 2012-09-19, 05:28