|
|
-
Re: Review Request: SQOOP-776 Sqoop2: show connection command shows password in plain textCheolsoo Park 2012-12-17, 21:04
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8620/#review14608 ----------------------------------------------------------- Ship it! Verified. Thanks Jarcec! sqoop:000> show connection -a 1 connection(s) to show: Connection with id 1 and name: c Configuration configuration JDBC Driver Class: oracle.jdbc.OracleDriver JDBC Connection String: jdbc:oracle:thin:@//oracle.ent.cloudera.com/XE Username: sqoop Password: (This input is sensitive) JDBC Connection Properties: Security related configuration options Max connections: - Cheolsoo Park On Dec. 15, 2012, 10:57 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8620/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2012, 10:57 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've hacked current code to stop printing sensitive information and improved the user experience by printing input type specific information. > > > This addresses bug SQOOP-776. > https://issues.apache.org/jira/browse/SQOOP-776 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 97eea795f7c5ebc9eab5e7f8741022342d55eb1d > > Diff: https://reviews.apache.org/r/8620/diff/ > > > Testing > ------- > > > Thanks, > > Jarek Cecho > > |