Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-850 Sqoop2: Move server initialization from server module to core


Copy link to this message
-
Re: Review Request: SQOOP-850 Sqoop2: Move server initialization from server module to core
Jarek Cecho 2013-01-31, 16:43


> On Jan. 30, 2013, 11:29 p.m., Cheolsoo Park wrote:
> > I found the method names are swapped. Is this intentional or a mistake?

Hi Cheolsoo,
thank you very much for your review and catching this embarrassing bug.

Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9071/#review15899
-----------------------------------------------------------
On Jan. 31, 2013, 4:43 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9071/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 4:43 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've moved initialization and destroyer logic to newly created class SqoopServer.
>
>
> This addresses bug SQOOP-850.
>     https://issues.apache.org/jira/browse/SQOOP-850
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java PRE-CREATION
>   server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 5998e01e9b7388d561b16079dedbf9ab808aad85
>
> Diff: https://reviews.apache.org/r/9071/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've run simple import on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>