Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 15375: HIVE-5683 JDBC support for char


Copy link to this message
-
Re: Review Request 15375: HIVE-5683 JDBC support for char


> On Nov. 9, 2013, 2:47 p.m., Xuefu Zhang wrote:
> > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java, line 138
> > <https://reviews.apache.org/r/15375/diff/1/?file=381307#file381307line138>
> >
> >     Could you remove the trailing space/tab?

Ok, will fix in next patch
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15375/#review28616
-----------------------------------------------------------
On Nov. 8, 2013, 11:05 p.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15375/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 11:05 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5683
>     https://issues.apache.org/jira/browse/HIVE-5683
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> thrift/jdbc changes for char.
>
>
> Diffs
> -----
>
>   data/files/datatypes.txt 10daa1b
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java a270cc6
>   jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b693e93
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 25faf48
>   jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 79e8c8c
>   jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java d612cf6
>   jdbc/src/java/org/apache/hive/jdbc/Utils.java 45de290
>   service/if/TCLIService.thrift 1f49445
>   service/src/gen/thrift/gen-cpp/TCLIService_constants.h 7471811
>   service/src/gen/thrift/gen-cpp/TCLIService_constants.cpp d085b30
>   service/src/gen/thrift/gen-cpp/TCLIService_types.h 490b393
>   service/src/gen/thrift/gen-cpp/TCLIService_types.cpp a3fd46c
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TCLIServiceConstants.java 7b4c576
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java 5d353f7
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java 15f2973
>   service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeId.java be70a3a
>   service/src/gen/thrift/gen-py/TCLIService/constants.py 589ce88
>   service/src/gen/thrift/gen-py/TCLIService/ttypes.py b286b05
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_constants.rb 8c341c8
>   service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c608364
>   service/src/java/org/apache/hive/service/cli/ColumnValue.java 62e221b
>   service/src/java/org/apache/hive/service/cli/Type.java f414fca
>   service/src/java/org/apache/hive/service/cli/TypeQualifiers.java 66a4b12
>
> Diff: https://reviews.apache.org/r/15375/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>