It seems for some time, the hadoopqa script cannot apply the patches generated for -p0. I've emailed Giri about it, who recently moved the jenkins builds nodes in builds.apache.org. We believe that the issue maybe about the default shell not being bash, but waiting for him to come back from vacation.
In the meantime I've disabled the smart handling of -p0 patches. The patch application should work now except for patches which just add new files. If you have such a patch, please make sure that it is generated for -p0.
I don't think we should have much formatting restrictions around patches. git format patch is nice to use, and if the author provides it the committers can use, but I don't think we should force that for every patch.
just my 2 cents. Enis On Sat, Jul 19, 2014 at 1:48 AM, Aditya <[EMAIL PROTECTED]> wrote:
I did not mean that we enforce this, rather encourage.
Would make committers' and reviewers' job easier. On Sun, Jul 20, 2014 at 4:06 AM, Ted Yu <[EMAIL PROTECTED]> wrote:
NEW: Monitor These Apps!
Apache Lucene, Apache Solr and all other Apache Software Foundation projects and their respective logos are trademarks of the Apache Software Foundation.
Elasticsearch, Kibana, Logstash, and Beats are trademarks of Elasticsearch BV, registered in the U.S. and in other countries. This site and Sematext Group is in no way affiliated with Elasticsearch BV.
Service operated by Sematext