Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 16650: FLUME-2225 Elasticsearch Sink for ES HTTP API


Copy link to this message
-
Re: Review Request 16650: FLUME-2225 Elasticsearch Sink for ES HTTP API
Ashish Paliwal 2014-01-29, 10:57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16650/#review33095
-----------------------------------------------------------

flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
<https://reviews.apache.org/r/16650/#comment62363>

    Minor - Can we make functions of the class static?

flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
<https://reviews.apache.org/r/16650/#comment62360>

    Can we move these constants to ElasticSearchConstants

flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
<https://reviews.apache.org/r/16650/#comment62361>

    Better to throw an Exception here, else it would result in NPE in ElasticSearchSink

flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java
<https://reviews.apache.org/r/16650/#comment62362>

    Better to throw exception stating invalid configuration
- Ashish Paliwal
On Jan. 7, 2014, 9:59 a.m., Pawe? wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16650/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 9:59 a.m.)
>
>
> Review request for Flume, Brock Noland, Hari Shreedharan, and Mike Percy.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> The patch contains changes in elasticsearch sink. It gives possibility to swich between Transport Client and REST Client to elasticsearch.
> Jest library (https://github.com/searchbox-io/Jest) client was used to communicate with elasticsearch by HTTP API. It uses guava 14 so it was necessary also to change version of guava used in flume (11.0.2 -> 14.0.1)
>
> Patch FLUME-2225-0.patch
>
>
> Diffs
> -----
>
>   flume-ng-core/pom.xml e41bcc2
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java 557d121
>   flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml bdc21d1
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchIndexRequestBuilderFactory.java 6effe34
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchIndexBuilder.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchIndexRequestBuilderFactory.java 8e77a1e
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java e38ab19
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkConstants.java dd0c59d
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/EventSerializerIndexRequestBuilderFactory.java c71b2e5
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/IndexNameBuilder.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/TimeBasedIndexNameBuilder.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/TimestampedEvent.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClient.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchClientFactory.java PRE-CREATION
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchRestClient.java PRE-CREATION