Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 17237: Patch for FLUME-1892 - IRC Sink NPE


Copy link to this message
-
Re: Review Request 17237: Patch for FLUME-1892 - IRC Sink NPE
Hari Shreedharan 2014-01-27, 06:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17237/#review32814
-----------------------------------------------------------

Ship it!
Ship It!

- Hari Shreedharan
On Jan. 23, 2014, 2:39 p.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17237/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2014, 2:39 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-1892
>     https://issues.apache.org/jira/browse/FLUME-1892
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Added fix for NPE when splitLines variable is not set
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-irc-sink/src/main/java/org/apache/flume/sink/irc/IRCSink.java 8e77218
>   flume-ng-sinks/flume-irc-sink/src/test/java/org/apache/flume/sink/irc/TestIRCSink.java e69de29
>
> Diff: https://reviews.apache.org/r/17237/diff/
>
>
> Testing
> -------
>
> Added test case to verify that Sink works fine, even if the splitLines property is not set
>
>
> Thanks,
>
> Ashish Paliwal
>
>