Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume >> mail # dev >> Review Request 24202: FLUME-2438 Make Syslog source message body configurable


Copy link to this message
-
Re: Review Request 24202: FLUME-2438 Make Syslog source message body configurable

Basically it goes back to the public vs. private thing... seemed weird to me that we would include a full test in the SyslogAgent and also provide public methods that no one outside SyslogAgent was calling. Seems to violate SRP. Since this is a test class, it is less critical, but it's also an infrastructure class, so worth thinking about.
- Mike
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24202/#review50204
On Aug. 12, 2014, 1:52 a.m., Abraham Elmahrek wrote: