Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager


+
Mengwei Ding 2013-06-17, 22:33
+
Jarek Cecho 2013-06-18, 14:51
+
Mengwei Ding 2013-06-19, 00:17
Copy link to this message
-
Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager
Mengwei Ding 2013-06-19, 00:48


> On June 18, 2013, 2:51 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java, lines 607-612
> > <https://reviews.apache.org/r/11920/diff/1/?file=307253#file307253line607>
> >
> >     There seems to be duplicity with similar code fragment in initialize() method, maybe it's worth abstracting into a method?

Well, yes, there seems to be a little duplicity of checking class name. However, in initialize(), it checks the instantiated class rather than the class name string. Seems a little bit different.

Also, I am not sure, but is it necessary to create a small method, like validateClassName(String)? Feels a little weird...:)   (Maybe I got you wrong. please correct me if I did.)
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11920/#review22027
-----------------------------------------------------------
On June 17, 2013, 10:33 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11920/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 10:33 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 719aeaab2cd74338399f43c411f7dccd95089c7b
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jun 12 15:47:26 2013 -0700
>
>     SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager
>
> :100644 100644 500189a... 5ea1ab3... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
> :100644 100644 f59d132... eb7c1dc... M core/src/main/java/org/apache/sqoop/core/CoreError.java
> :000000 100644 0000000... 3c7d004... A core/src/main/java/org/apache/sqoop/core/Reconfigurable.java
> :100644 100644 deb24c9... 6d9a177... M core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
> :100644 100644 145a2c1... 38fa932... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
> :100644 100644 3339c59... 6240aac... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
> :100644 100644 955306d... 53aef5d... M core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
> :100644 100644 4ea52e9... 1ec6bdf... M core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java
> :100644 100644 de9a24b... ae8686b... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> This addresses bug SQOOP-971.
>     https://issues.apache.org/jira/browse/SQOOP-971
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 500189a
>   core/src/main/java/org/apache/sqoop/core/CoreError.java f59d132
>   core/src/main/java/org/apache/sqoop/core/Reconfigurable.java PRE-CREATION
>   core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java deb24c9
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 145a2c1
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java 3339c59
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java 955306d
>   core/src/main/java/org/apache/sqoop/repository/RepositoryProvider.java 4ea52e9
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java de9a24b
>
> Diff: https://reviews.apache.org/r/11920/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>

+
Mengwei Ding 2013-06-19, 00:58
+
Mengwei Ding 2013-06-19, 01:06
+
Jarek Cecho 2013-06-19, 23:39
+
Mengwei Ding 2013-06-21, 18:12
+
Jarek Cecho 2013-06-21, 19:39
+
Mengwei Ding 2013-06-21, 20:42
+
Jarek Cecho 2013-06-21, 23:12