Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-919 Sqoop2: Improve Form API for simple java handling


Copy link to this message
-
Re: Review Request: SQOOP-919 Sqoop2: Improve Form API for simple java handling
rj.vasanthkumar@... 2013-03-05, 18:07

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9745/#review17411
-----------------------------------------------------------

common/src/test/java/org/apache/sqoop/model/TestMFormList.java
<https://reviews.apache.org/r/9745/#comment36939>

    I think we have to use MFormList class with this test case logic. Sorry If I am wrong.
- vasanthkumar
On March 5, 2013, 6:08 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9745/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 6:08 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've tried to simplify the Java API from perspective of third party user that is integrating with Sqoop.
>
>
> This addresses bug SQOOP-919.
>     https://issues.apache.org/jira/browse/SQOOP-919
>
>
> Diffs
> -----
>
>   common/src/main/java/org/apache/sqoop/model/MConnection.java bc730bbd1b31f8c48710894e401430412820f51b
>   common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 45e4666f83e484047ae7e8edc8b1a77bbdd34cde
>   common/src/main/java/org/apache/sqoop/model/MEnumInput.java bed2b040c8aa497a4d53a807e35434842dbce344
>   common/src/main/java/org/apache/sqoop/model/MForm.java a55fe65b2830f307db6304d31f6398f03482477f
>   common/src/main/java/org/apache/sqoop/model/MFormList.java PRE-CREATION
>   common/src/main/java/org/apache/sqoop/model/MJobForms.java 0945a6a2e8e81216e8dac2153e2d433577b83dbc
>   common/src/main/java/org/apache/sqoop/model/ModelError.java f8d61ef61a6e610452c74b02ffcd033c054183d3
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java.orig b63fce2aae67261cc5d98f73aae326101f91f27c
>   common/src/test/java/org/apache/sqoop/model/TestMConnection.java d5f9f38c07e2d54fe86b4d46bcd3f7c974eace45
>   common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java 0a3392c9083f1caab3182b88afa3b5c75245a8b7
>   common/src/test/java/org/apache/sqoop/model/TestMForm.java 38443a78daf216f3a9fc64e7bf86f4cdd7fffe46
>   common/src/test/java/org/apache/sqoop/model/TestMFormList.java PRE-CREATION
>   test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java 20588d31da48ac93d979718c22fb4e179d6b2d19
>
> Diff: https://reviews.apache.org/r/9745/diff/
>
>
> Testing
> -------
>
> I've added or tweak unit tests to cover the new functionality. I've also altered the integration test to utilize this API.
>
>
> Thanks,
>
> Jarek Cecho
>
>