Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-662 Introduce pluggable configuration objects


Copy link to this message
-
Review Request: SQOOP-662 Introduce pluggable configuration objects
Jarek Cecho 2012-11-13, 20:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8040/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've implement the "pluggability" on form level, when multiple forms can be easily reused in multiple configuration classes as each form is now separate class.
This addresses bug SQOOP-662.
    https://issues.apache.org/jira/browse/SQOOP-662
Diffs
-----

  client/src/main/resources/client-resource.properties 793ddc8d5d5c7281e35413152e56e83a264014ac
  common/src/main/java/org/apache/sqoop/model/Configuration.java 1331c7ed7d5e4025f873940057619bd154cc34be
  common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java PRE-CREATION
  common/src/main/java/org/apache/sqoop/model/Form.java PRE-CREATION
  common/src/main/java/org/apache/sqoop/model/FormClass.java PRE-CREATION
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 418b0a7da924afc9a457d8a8f5bf5f388e127662
  common/src/main/java/org/apache/sqoop/model/Input.java 6b3973b0d466985814e6ee1a02b87a3d138ca21c
  common/src/main/java/org/apache/sqoop/model/MNamedElement.java e67a78ca41f60e958c94632f6b05fe70616ba2f8
  common/src/main/java/org/apache/sqoop/model/ModelError.java 2c496cec77f3807da42c028afba9c45e9a28db99
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java c19f9bd2b26d38beef5a306e9f72d0824f51d751
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 72b992c784ff3fe9ef2d73438253a3634da8f906
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java f8e941cb5c9ef5d553d3b5e027d89bf1c34cf0c4
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java a6e7bbf1abaa1a9d3a037fffeb29bcb18c3e1fc5
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java f9b8e1b23e31611c6944367bef44412182493b98
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionForm.java PRE-CREATION
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java e54e7db8b8a5065b65f4877990351ba636010a4c
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IgnoredForm.java PRE-CREATION
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java b03cdbd59a0ef392434c0995912a0add6a3f7812
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/TableForm.java PRE-CREATION
  connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties 9b0b9ab6a84236ca8227a05c379ca6497b755e75
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java 24bbb415e335bbec3fac1be7a9d8613394b58ce6
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 8957ed153e5fcaf3a9ca6755be8c35ee2f575866
  core/src/main/java/org/apache/sqoop/framework/FrameworkConstants.java 32da4e84238e01eae799f389476e9e153e2292dc
  core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java d04a100e7591f95eca1bf0f09707b85e0d9f2054
  core/src/main/java/org/apache/sqoop/framework/configuration/ConnectionConfiguration.java bcf4dadbaec2631f582c67a4b31879507e5cd615
  core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java 90541e9650198e2fd81df2d38dec0c472525cf0d
  core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java d811593d82e862511eb023afc63a478ee04518d8
  core/src/main/java/org/apache/sqoop/framework/configuration/OutputForm.java PRE-CREATION
  core/src/main/java/org/apache/sqoop/framework/configuration/SecurityForm.java PRE-CREATION
  core/src/main/resources/framework-resources.properties 872f48e913d3919a5c238da03600035371c4daa3
  server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 64ef84a89e94fc2be8ed4f4b0b7cf6c10485087f
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 070b290b11eea89b8d756857a302b713d3e345c6

Diff: https://reviews.apache.org/r/8040/diff/
Testing

Tests are passing and I've tested changes on real cluster.
Thanks,

Jarek Cecho