Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Sqoop2: Help option for shell command functions


Copy link to this message
-
Re: Review Request: Sqoop2: Help option for shell command functions
Jarek Cecho 2013-04-13, 19:01

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10100/#review19127
-----------------------------------------------------------
Hi Vasanth,
thank you for working on this patch, greatly appreciated. I do have one comment:
client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
<https://reviews.apache.org/r/10100/#comment39682>

    I would argue that this might be quite confusing for end user as "show connection --jid 1 help" will show the help but "show connection help --jid 1" won't. I think that using just the "help" command for getting help will be enough, what do you think?
Jarcec

- Jarek Cecho
On April 8, 2013, 8:28 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10100/
> -----------------------------------------------------------
>
> (Updated April 8, 2013, 8:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> There is no help option for shell command's functions. Introducing the help argument for functions.
>
>
> This addresses bug sqoop-965.
>     https://issues.apache.org/jira/browse/sqoop-965
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java c6f831d
>   client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java bf26761
>
> Diff: https://reviews.apache.org/r/10100/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>