Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # user - builtins submodule - is it still needed?


Copy link to this message
-
Re: builtins submodule - is it still needed?
Travis Crawford 2013-04-06, 00:02
Thanks for the background – I've filed
https://issues.apache.org/jira/browse/HIVE-4304 and will remove them.

--travis

On Fri, Apr 5, 2013 at 4:45 PM, Owen O'Malley <[EMAIL PROTECTED]> wrote:
> +1 to removing them.
>
> We have a Rot13 example in
> ql/src/test/org/apache/hadoop/hive/ql/io/udf/Rot13{In,Out}putFormat.java
> anyways. *smile*
>
> -- Owen
>
>
> On Fri, Apr 5, 2013 at 3:11 PM, Gunther Hagleitner
> <[EMAIL PROTECTED]> wrote:
>>
>> +1
>>
>> I would actually go a step further and propose to remove both PDK and
>> builtins. I've went through the code for both and here is what I found:
>>
>> Builtins:
>> - BuiltInUtils.java: Empty file
>> - UDAFUnionMap: Merges maps. Doesn't seem to be useful by itself, but was
>> intended as a building block for PDK
>>
>> PDK:
>> - some helper build.xml/test setup + teardown scripts
>> - Classes/annotations to help run unit tests
>> - rot13 as an example
>>
>> From what I can tell it's a fair assessment that it hasn't taken off, last
>> commits to it seem to have happened more than 1.5 years ago.
>>
>> Thanks,
>> Gunther.
>>
>>
>>
>> On Thu, Apr 4, 2013 at 2:01 PM, Travis Crawford <[EMAIL PROTECTED]>
>> wrote:
>>>
>>> Hey hive gurus -
>>>
>>> Is the "builtins" hive submodule in use? The submodule was added in
>>> HIVE-2523 as a location for builtin-UDFs, but it appears to not have
>>> taken off. Any objections to removing it?
>>>
>>> DETAILS
>>>
>>> For HIVE-4278 I'm making some build changes for the HCatalog
>>> integration. The "builtins" submodule causes issues because it delays
>>> building until the packaging phase - so HCatalog can't depend on
>>> builtins, which it does transitively.
>>>
>>> While investigating a path forward I discovered the "builtins"
>>> submodule contains very little code, and likely could either go away
>>> entirely or merge into "ql", simplifying things both for users and
>>> developers.
>>>
>>> Thoughts? Can anyone with context help me understand "builtins", both
>>> in general and around its non-standard build? For your trouble I'll
>>> either make the submodule go away/merge into another submodule, or
>>> update the docs with what we learn.
>>>
>>> Thanks!
>>> Travis
>>
>>
>