Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Zookeeper >> mail # dev >> Review Request 24208: ZOOKEEPER-1994


Copy link to this message
-
Re: Review Request 24208: ZOOKEEPER-1994

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24208/#review50250

src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
<https://reviews.apache.org/r/24208/#comment87910>

    nits about style:
    
    * space between if and (
    
    * if statements always have {} in their body (i.e.: if (cond) { })

src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
<https://reviews.apache.org/r/24208/#comment87913>

    nit: spaces between if and ( and in the cond

src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
<https://reviews.apache.org/r/24208/#comment87915>

    ditto

src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
<https://reviews.apache.org/r/24208/#comment87916>

    ditto

src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
<https://reviews.apache.org/r/24208/#comment87917>

    ditto

src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
<https://reviews.apache.org/r/24208/#comment87919>

    no need for the surround ()s
- Raul Gutierrez Segales
On Aug. 8, 2014, 2:54 p.m., Hongchao Deng wrote: