Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
MapReduce, mail # dev - [Vote] Merge branch-trunk-win to trunk

Suresh Srinivas 2013-02-26, 22:55
Robert Evans 2013-02-27, 16:17
Eli Collins 2013-02-27, 19:56
Suresh Srinivas 2013-02-27, 22:54
Todd Lipcon 2013-02-27, 23:43
Ivan Mitic 2013-02-28, 02:32
John Gordon 2013-02-28, 11:25
Chris Nauroth 2013-02-28, 16:45
Robert Evans 2013-02-28, 19:29
Chris Nauroth 2013-02-28, 19:50
Harsh J 2013-02-27, 19:20
Konstantin Shvachko 2013-03-02, 03:14
Konstantin Shvachko 2013-03-01, 20:18
Chris Douglas 2013-03-01, 21:28
Konstantin Shvachko 2013-03-01, 21:57
Chris Douglas 2013-03-02, 00:57
Konstantin Boudnik 2013-03-01, 23:47
Suresh Srinivas 2013-03-02, 01:55
Konstantin Boudnik 2013-03-02, 03:33
Matt Foley 2013-03-02, 20:32
Copy link to this message
Re: [Vote] Merge branch-trunk-win to trunk
Konstantin Shvachko 2013-03-03, 03:32
Hi Matt,

On Sat, Mar 2, 2013 at 12:32 PM, Matt Foley <[EMAIL PROTECTED]> wrote:
> Konstantin,
> I would like to explore what it would take to remove this perceived
> impediment --

Glad you decided to explore. Thank you.

> although I reserve the right to argue that this is not
> pre-requisite to merging the cross-platform support patch.

It's your right indeed. So as mine to question what the platform
support means for you, which I believe remained unclear.
I do not impede the change as you should have noticed. My requirement
comes from my perception of the support, which means to me exactly two
1. The ability to recognise the code is broken for the platform
2. The ability to test new patches on the platform
The latter is problematic, as many noticed in this thread, for those
whose customary environment does not include Windows.

> If we implemented full "test-patch" support for Windows on trunk, would that
> fulfill both your items #1 and #2?  Please note that:
> a) Pushing the "Patch Available" button in Jira shall cause a pre-commit
> build to start within, I believe, 20 minutes.
> b) That build keeps logs for both java build and unit tests for several
> days, that are accessible to all viewers.

In item #1 I mostly asking for the nightly build, which is simpler
than "test-patch". The latter would be ideal from the platform support
viewpoint, but it is for the community to decide if we want to add
extra +3 hours to the build.
Nightly build in my understanding is triggered by the timer rather
than by Jira's "submit patch" button.  On Jenkins build configuration
you can specify it under "Build periodically".

> So, does this provide sufficient on-demand support that we don't have to
> implement a whole new on-demand VM support structure of some sort for #2
> (which would be an extraordinary and impractical demand)?

I did not mention VMs. Item #2 means a build, which runs "test-patch"
target with the file specified by a user (instead of a jira
When user clicks "Build Now" link a box is displayed where the user
can enter the file path containing the patch. This can be specified in
the Build Configuration under "This build is parameterized" by
choosing AddParameter / FileParameter. The build can run on the same
Windows machine as the nightly build.
Such build will let people test their patches for Windows on Jenkins
if they don't posses a license for the right version of Windows.
I hope this will not turn into extraordinary or impractical effort.


> Thanks,
> --Matt
> On Fri, Mar 1, 2013 at 12:18 PM, Konstantin Shvachko <[EMAIL PROTECTED]>
> wrote:
>> -1
>> We should have a CI infrastructure in place before we can commit to
>> supporting Windows platform.
>> Eric is right Win/Cygwin was supported since day one.
>> I had a Windows box under my desk running nightly builds back in 2006-07.
>> People were irritated but I was filing windows bugs until 0.22 release.
>> Times changing and I am glad to see wider support for Win platform.
>> But in order to make it work you guys need to put the CI process in place
>> 1. windows jenkins build: could be nightly or PreCommit.
>> - Nightly would mean that changes can be committed to trunk based on
>> linux PreCommit build. And people will file bugs if the change broke
>> Windows nightly build.
>> - PreCommit-win build will mean automatic reporting failed tests to
>> respective jira blocking commits the same way as it is now with linux
>> PreCommit builds.
>> We should discuss which way is more efficient for developers.
>> 2. On-demand-windows Jenkins build.
>> I see it as a build to which I can attach my patch and the build will
>> run my changes on a dedicated windows box.
>> That way people can test their changes without having personal windows
>> nodes.
>> I think this is the minimal set of requirement for us to be able to
>> commit to the new platform.
>> Right now I see only one windows related build
>> https://builds.apache.org/view/Hadoop/job/Hadoop-1-win/
Matt Foley 2013-03-03, 19:08
Konstantin Shvachko 2013-03-03, 20:16
Bikas Saha 2013-03-01, 17:55
Konstantin Boudnik 2013-03-01, 01:04
Ramya Sunil 2013-03-01, 00:59
Suresh Srinivas 2013-03-06, 19:50
Andrew Purtell 2013-03-25, 20:36
Suresh Srinivas 2013-03-26, 00:08