Thanks for that. I agree there's no point to attribute your own code to
yourself :-) but that committing someone else's work without attribution in
the commit log is in my view taking credit for their work. Just my opinion.
On Mon, Jan 20, 2014 at 4:39 PM, Jesse Yates <[EMAIL PROTECTED]>wrote:
> +1 To continue giving attribution (unless you wrote the code, in which
> case, whats the point, eh?)
> Jesse Yates
> On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <[EMAIL PROTECTED]>
> > I see some committers are continuing the informal practice we've had of
> > attribution in parenthesis after the issue description if the work is not
> > your own, e.g.
> > HBASE-XXXX. JIRA title goes here (Contributor Name)
> > I've noticed that some committers are definitely not doing this.
> > I think it is bad practice not to provide attribution to the contributor
> > the commit message. When one is reviewing commit history, neither links
> > JIRA nor inlining of JIRA content is possible -- unless there is some
> > that does this of which I'm not aware (please let me know!).
> > --
> > Best regards,
> > - Andy
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)