Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 15629: SQOOP-1233 Sqoop2: Remove unnecessary explicit call to MessageFormat


Copy link to this message
-
Review Request 15629: SQOOP-1233 Sqoop2: Remove unnecessary explicit call to MessageFormat

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15629/
-----------------------------------------------------------

Review request for Sqoop.
Bugs: SQOOP-1233
    https://issues.apache.org/jira/browse/SQOOP-1233
Repository: sqoop-sqoop2
Description
-------

I've removed the explicit call to MessageFormat by passing the formatting down.
Diffs
-----

  shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java e8d531fe51d342d800beac7ce2552bd911fb791d
  shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 8be2e54414e27cc1d4e1f508f2ca361d127ef8bd

Diff: https://reviews.apache.org/r/15629/diff/
Testing
-------
Thanks,

Jarek Cecho