Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Review Request: SQOOP-774 Sqoop2: exception is thrown when creating a connection object if connectionString starts with an empty space


Copy link to this message
-
Review Request: SQOOP-774 Sqoop2: exception is thrown when creating a connection object if connectionString starts with an empty space

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8621/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

The problem was that we did not updated Validation part when we were migrating forms to "object" structures.
This addresses bug SQOOP-774.
    https://issues.apache.org/jira/browse/SQOOP-774
Diffs
-----

  common/src/main/java/org/apache/sqoop/json/ValidationBean.java 1ad8186c471264d5fd92367bc8a680125213a5c4
  common/src/main/java/org/apache/sqoop/model/FormUtils.java 05941f6fc450d3aa6c83595eaf84363c62f7d51b
  common/src/main/java/org/apache/sqoop/validation/Validation.java e4398b66eae6a844b11dc93924c879ecf59a3159
  common/src/main/java/org/apache/sqoop/validation/ValidationError.java 0c7e0edcab49a81cc2015fc4f75e1f992cbe43a8
  common/src/test/java/org/apache/sqoop/json/TestValidationBean.java bdef7e81beaae2d440617cb5dd471eeb1454d7db
  common/src/test/java/org/apache/sqoop/model/TestFormUtils.java f17155f20cb15882da9cf70c24fb86e2cf5f65ad
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 52ad2dcb67aefba816cf3fa8a7cd26dbda6dfd94

Diff: https://reviews.apache.org/r/8621/diff/
Testing
-------

Unit tests are passing and I've done test on real cluster.
Thanks,

Jarek Cecho

+
Cheolsoo Park 2012-12-17, 19:42