Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Drill >> mail # dev >> Review Request 13760: DRILL abs() function implementation


Copy link to this message
-
Review Request 13760: DRILL abs() function implementation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/
-----------------------------------------------------------

Review request for drill.
Repository: drill-git
Description
-------

Implementation of the abs() function within DRILL.
Diffs
-----

  sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockRecordReader.java 024aa21
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd

Diff: https://reviews.apache.org/r/13760/diff/
Testing
-------

org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
Thanks,

Tanujit Ghosh

+
Tanujit Ghosh 2013-08-23, 04:18
+
Tanujit Ghosh 2013-08-27, 02:19