Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms


Copy link to this message
-
Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms


> On Oct. 29, 2013, 3:25 p.m., kturner wrote:
> > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java, line 385
> > <https://reviews.apache.org/r/14972/diff/1/?file=371882#file371882line385>
> >
> >     Mini is intended to be user facing and allow user to test their code against Accumulo.  We keep exposing methods in the minicluster public API inorder for Accumulo to test Accumulo.  I worry that the more we expose in its API the more we will box ourselves in for future changes to mini (like speeding it up some way).  
> >    
> >     This is a general concern I have, not specific to this change.  This change is following the general trend for mini.  I have not had time to pursue, but I have wondered if it would be worthwhile to create a mini for internal use and one for external use (with a more minimal API).  This may not be worthwhile.  
> >
>
> John Vines wrote:
>     This sounds like something that should be written up in it's own ticket
>
> Michael Berman wrote:
>     I'm not sure I agree that this is exclusive to us testing accumulo...  On a big cluster, system props can be set in accumulo-env.sh, so it makes sense to me that there would also be a way to set them in a minicluster.
>    
>     That said, I don't think we actually need it for the SSL changeset quite yet.  I added it so that I could test JSSE, but it turns out that doesn't work at all with the ZK/JSSE incompatibility, so if it's controversial we could take it out.  But I'll want it back in if ZOOKEEPER-1554 gets addressed and we want to flesh out JSSE support.
>
> Sean Busbey wrote:
>     +1 for removal.
>    
>     I'd rather see discussion on the dev@ list about Mini internal-vs-external than a ticket.

Sure, either way it's not in the scope of this ticket.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14972/#review27675
-----------------------------------------------------------
On Oct. 31, 2013, 2:35 p.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14972/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 2:35 p.m.)
>
>
> Review request for accumulo and Michael Berman.
>
>
> Bugs: ACCUMULO-1009
>     https://issues.apache.org/jira/browse/ACCUMULO-1009
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Michael Berman's October 13 patch for ACCUMULO-1009
>
>
> Diffs
> -----
>
>   .gitignore 1ffa452
>   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 5b5d041
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java bb5987d
>   core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 32c80f9
>   core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java 218bd36
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 0376304
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java 0dd86bf
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java f07139d
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java e7dabb5
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java bbbd0c3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java 908b8b3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java fe5003b
>   core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java c796cd2
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java 1cbb606
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 727bfec