Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> Re: Review Request: HBase-2001: Coprocessors: Colocate user code with regions


Copy link to this message
-
Re: Review Request: HBase-2001: Coprocessors: Colocate user code with regions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/876/#review1380
-----------------------------------------------------------
Sorry for all the whitespace comments :)
There are a bunch more in the test classes.
src/main/java/org/apache/hadoop/hbase/HServerInfo.java
<http://review.cloudera.org/r/876/#comment4581>

    The ternary operator does not need braces.

src/main/java/org/apache/hadoop/hbase/client/Action.java
<http://review.cloudera.org/r/876/#comment4582>

    The ternary operator does not need braces.

src/main/java/org/apache/hadoop/hbase/client/Batch.java
<http://review.cloudera.org/r/876/#comment4583>

    Remove extra character(s)

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment4586>

    Should be of Type List<R> not ArrayList<R>

src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
<http://review.cloudera.org/r/876/#comment4585>

    Why is this necessary? You already set the size by using the correct constructor.

src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4588>

    Remove the "public", interfaces don't need that.

src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4589>

    Remove the "public", interfaces don't need that.
    
    Also byte[] key in Map so every implementor has to make sure to use a Map that does this correctly.

src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java
<http://review.cloudera.org/r/876/#comment4590>

    Remove the "public", interfaces don't need that.

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4591>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4592>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseCommandTarget.java
<http://review.cloudera.org/r/876/#comment4593>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4594>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4595>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4596>

    Inconsistent formatting

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4597>

    Inconsistent formatting

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4598>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4599>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4600>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4601>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4602>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4603>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4604>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<http://review.cloudera.org/r/876/#comment4605>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4612>

    Remove public static final

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4606>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4613>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4614>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4615>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4607>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4616>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4617>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4608>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4618>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4609>

    Whitespace stuff
    
    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4610>

    Whitespace stuff

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4619>

    Remove public

src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<http://review.cloudera.org/r/876/#comment4611>

    Whitespace stuff
    
    Remove public

src/main/java/org/apache/hado