DFSClient sometimes swallowed InterruptedException. Is that intended?

According to this, we should never swallow an InterruptedException. Application might use InterruptedException for thread cooperation.
http://www.ibm.com/developerworks/java/library/j-jtp05236.html

Shall we open a JIRA to fix this?

Zheng

I think we should open a JIRA and fix it. Code than runs as part of an
application should not swallow interrrupted exception.

thanks,
dhruba
On Tue, Jun 15, 2010 at 2:26 PM, Zheng Shao <[EMAIL PROTECTED]> wrote:

>  DFSClient sometimes swallowed InterruptedException. Is that intended?
>
>
>
> According to this, we should never swallow an InterruptedException.
> Application might use InterruptedException for thread cooperation.
>
> http://www.ibm.com/developerworks/java/library/j-jtp05236.html
>
>
>
> Shall we open a JIRA to fix this?
>
>
>
> Zheng
>
>
>

--
Connect to me at http://www.facebook.com/dhruba

Thanks Dhruba.

Opened https://issues.apache.org/jira/browse/HDFS-1208

On Tue, Jun 15, 2010 at 4:25 PM, Dhruba Borthakur <[EMAIL PROTECTED]> wrote:
> I think we should open a JIRA and fix it. Code than runs as part of an
> application should not swallow interrrupted exception.
> thanks,
> dhruba
>
> On Tue, Jun 15, 2010 at 2:26 PM, Zheng Shao <[EMAIL PROTECTED]> wrote:
>>
>> DFSClient sometimes swallowed InterruptedException. Is that intended?
>>
>>
>>
>> According to this, we should never swallow an InterruptedException.
>> Application might use InterruptedException for thread cooperation.
>>
>> http://www.ibm.com/developerworks/java/library/j-jtp05236.html
>>
>>
>>
>> Shall we open a JIRA to fix this?
>>
>>
>>
>> Zheng
>>
>>
>
>
> --
> Connect to me at http://www.facebook.com/dhruba
>

--
Yours,
Zheng
http://www.linkedin.com/in/zshao

On Jun 15, 2010, at 4:25 PM, Dhruba Borthakur wrote:

> I think we should open a JIRA and fix it. Code than runs as part of  
> an application should not swallow interrrupted exception.

I'm a big fan of removing the swallowing of interrupted exceptions.  
One word of caution however, the catches buried down in RPC are hard  
to remove with out breaking things. (In particular, the rpc protocols  
don't declare interrupted exception, so if you throw it through one of  
the proxy object methods, you'll get bad results.)

-- Owen

On Wed, Jun 16, 2010 at 11:38 AM, Owen O'Malley <[EMAIL PROTECTED]> wrote:

>
> On Jun 15, 2010, at 4:25 PM, Dhruba Borthakur wrote:
>
>  I think we should open a JIRA and fix it. Code than runs as part of an
>> application should not swallow interrrupted exception.
>>
>
> I'm a big fan of removing the swallowing of interrupted exceptions. One
> word of caution however, the catches buried down in RPC are hard to remove
> with out breaking things. (In particular, the rpc protocols don't declare
> interrupted exception, so if you throw it through one of the proxy object
> methods, you'll get bad results.)
>
>
This is partially improved in HADOOP-6762

-Todd
>  -- Owen
>

--
Todd Lipcon
Software Engineer, Cloudera