Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: Sqoop2: Improve user experience on synchronous job submission


+
rj.vasanthkumar@... 2013-05-22, 21:27
+
Jarek Cecho 2013-05-23, 06:51
+
rj.vasanthkumar@... 2013-05-23, 21:05
+
rj.vasanthkumar@... 2013-05-24, 12:33
+
Jarek Cecho 2013-05-27, 06:11
Copy link to this message
-
Re: Review Request: Sqoop2: Improve user experience on synchronous job submission
Jarek Cecho 2013-05-24, 09:11

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11336/#review20988
-----------------------------------------------------------
Hi Vasanth,
I like your changes, they are great! I do have just couple of nits:

When getting status of finished job it seems that the first line is a bit messed up and also the counters seems to be missing:

sqoop:000> submission status --jid 1
2013-05-24 02:04:54 PDT: SUCCEEDEDSubmission details
Job ID: 1
Server URL: http://vojnar-1.ent.cloudera.com:12000/sqoop/
Creation date: 2013-05-24 02:02:54 PDT
External ID: job_201303241602_0081
        http://vojnar-1.ent.cloudera.com:50030/jobdetails.jsp?jobid=job_201303241602_0081
- Jarek Cecho
On May 23, 2013, 9:04 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11336/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 9:04 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
>  Improve user experience on synchronous job submission
>
>
> This addresses bug SQOOP-984.
>     https://issues.apache.org/jira/browse/SQOOP-984
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 8c3c6a4
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java 7009da2
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java 48db8ab
>   client/src/main/java/org/apache/sqoop/client/shell/SubmissionStopFunction.java 8291a54
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java c56cefd
>   client/src/main/resources/client-resource.properties c7a4cb3
>   docs/src/site/sphinx/CommandLineClient.rst 1b9676f
>
> Diff: https://reviews.apache.org/r/11336/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

+
rj.vasanthkumar@... 2013-05-23, 21:04