Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo


Copy link to this message
-
Re: Review Request 16533: Add StoreFunc and LoadFunc classes to Pig for Accumulo
Daniel Dai 2014-01-17, 06:18


> On Jan. 16, 2014, 12:42 a.m., Daniel Dai wrote:
> > Excellent job!
> >
> > The only thing I find is we still need getLoadCaster in AbstractAccumuloStorage.java
> >
> >   @Override
> >   public LoadCaster getLoadCaster() throws IOException {
> >       return caster;
> >   }
> >
> > I can add it before commit if you don't mind.
>
> Daniel Dai wrote:
>     Another question, why TestAccumuloPigCluster is disabled for hadoop 2? No hadoop 2 support for accumulo?
>
> Josh Elser wrote:
>     Feel free to make the change. I'm a little indisposed the rest of this week.
>    
>     I think I tried running that test with hadoop2 and I got some obscure failure that I hadn't seen before. Accumulo itself works just fine with Hadoop2. Up to you if we want to figure it out before this is committed -- I forgot about it, tbh.

I am fine to commit it now and figure out it later, but be sure to open a Jira ticket to track it.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16533/#review31974
-----------------------------------------------------------
On Jan. 15, 2014, 12:44 a.m., Josh Elser wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16533/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 12:44 a.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-3573
>     https://issues.apache.org/jira/browse/PIG-3573
>
>
> Repository: pig-git
>
>
> Description
> -------
>
> Provides basic StoreFunc and LoadFunc implementations. Based off of code that was in an Accumulo contrib project.
>
>
> Diffs
> -----
>
>   ivy.xml 180eb2c
>   ivy/libraries.properties 14abdf8
>   src/org/apache/pig/backend/hadoop/accumulo/AbstractAccumuloStorage.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/AccumuloBinaryConverter.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorage.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/AccumuloStorageOptions.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/Column.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/FixedByteArrayOutputStream.java PRE-CREATION
>   src/org/apache/pig/backend/hadoop/accumulo/Utils.java PRE-CREATION
>   test/excluded-tests-23 aaf6bd1
>   test/org/apache/pig/backend/hadoop/accumulo/TestAbstractAccumuloStorage.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloBinaryConverter.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloColumns.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloPigCluster.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorage.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageConfiguration.java PRE-CREATION
>   test/org/apache/pig/backend/hadoop/accumulo/TestAccumuloStorageOptions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16533/diff/
>
>
> Testing
> -------
>
> Local tests reading, writing and JOIN'ing Accumulo tables. Tested against Hadoop-1.0.4 and 2.2.0, with Accumulo 1.5.0
>
>
> Thanks,
>
> Josh Elser
>
>