Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig >> mail # dev >> Re: Review Request: PIG-3322 Fix the issue where NPE is thrown when reading a union which has nulls and add a testcase


Copy link to this message
-
Re: Review Request: PIG-3322 Fix the issue where NPE is thrown when reading a union which has nulls and add a testcase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11333/#review21305
-----------------------------------------------------------

http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java
<https://reviews.apache.org/r/11333/#comment44204>

    If you use mock.Storage here instead of PigStoage, you won't need the verifyTextResults method and extra output file. Can you please update your test?
    
    Please see org.apache.pig.builtin.mock.Storage.java.
- Cheolsoo Park
On May 29, 2013, 11:07 p.m., Viraj Bhat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11333/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 11:07 p.m.)
>
>
> Review request for pig and Rohini Palaniswamy.
>
>
> Description
> -------
>
> Null pointer exception when loading union with null in it's schema. Test case was also updated with a sample test case.
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java 1485358
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 1485358
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1485358
>   http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/avro_test_files/expected_testLoadAvrowithNulls.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/11333/diff/
>
>
> Testing
> -------
>
> Yes all tests pass in the piggybank
>
>
> Thanks,
>
> Viraj Bhat
>
>