Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.


Copy link to this message
-
Re: Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.
Hari Shreedharan 2012-12-18, 20:58


> On Dec. 18, 2012, 8:34 p.m., Hari Shreedharan wrote:
> > flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java, line 340
> > <https://reviews.apache.org/r/8421/diff/2/?file=237476#file237476line340>
> >
> >     If channels list is empty should we throw? I think we should just remove the source and log it right?
>
> Brock Noland wrote:
>     FlumeConfiguration should have already eliminated these, correct? If not, wouldn't it be a bug in FlumeConfiguration?

If these channels were removed/not added because the configure method threw, this could still be empty even if FlumeConfiguration did not remove it.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8421/#review14378
-----------------------------------------------------------
On Dec. 12, 2012, 7:30 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8421/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2012, 7:30 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Catches Exception around all the configure() methods of components. If they throw an exception, they are removed from the configuration (not added).
>
>
> This addresses bug FLUME-1772.
>     https://issues.apache.org/jira/browse/FLUME-1772
>
>
> Diffs
> -----
>
>   flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java daef76b
>   flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java 25001b1
>
> Diff: https://reviews.apache.org/r/8421/diff/
>
>
> Testing
> -------
>
> Tests added for source, channel, and sink.
>
>
> Thanks,
>
> Brock Noland
>
>