Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 12806: SQOOP-890: ClassWriter Generates setField Casts Based on the Output Type, not the Input Type


Copy link to this message
-
Re: Review Request 12806: SQOOP-890: ClassWriter Generates setField Casts Based on the Output Type, not the Input Type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12806/#review23728
-----------------------------------------------------------
Hi Nick,
thank you very much for working on this one! I would be interesting to known more about the reasoning for this change. Would you mind describing it a bit more?

I'm having concerns that this patch will allow automatic conversion from Long to Int that might lead to data loss without user knowing that. It also seems that the issue might be easily workarounded by explicitly using --map-java-type argument that will allow the advance users to overcome the issue, but still won't do any implicit conversions.

Jarcec

- Jarek Cecho
On July 22, 2013, 9:38 a.m., Nick White wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12806/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 9:38 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Sqoop should be more flexible when converting between number types.
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/orm/ClassWriter.java 1bd2a41
>   src/test/com/cloudera/sqoop/TestAvroExport.java 7016826
>
> Diff: https://reviews.apache.org/r/12806/diff/
>
>
> Testing
> -------
>
> Unit test included.
>
>
> Thanks,
>
> Nick White
>
>