-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

Move string constants from FormDisplayer to resource file
This addresses bug SQOOP-887.
    https://issues.apache.org/jira/browse/SQOOP-887
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java af325d5
  client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java c2464d2
  client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 31de8dc
  client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 0d67133
  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 4d0442f
  client/src/main/resources/client-resource.properties 58cfe55

Diff: https://reviews.apache.org/r/9669/diff/
Testing
-------

Done
Thanks,

vasanthkumar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/#review17679
-----------------------------------------------------------
Hi Vasanth,
would you mind rebasing your changes with current changes in head of the sqoop2 branch? I'll be happy to help or to take it from here if you're not interested any more.

Jarcec

- Jarek Cecho
On Feb. 28, 2013, 3:04 a.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2013, 3:04 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Move string constants from FormDisplayer to resource file
>
>
> This addresses bug SQOOP-887.
>     https://issues.apache.org/jira/browse/SQOOP-887
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java af325d5
>   client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java c2464d2
>   client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java 31de8dc
>   client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java 0d67133
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java 4d0442f
>   client/src/main/resources/client-resource.properties 58cfe55
>
> Diff: https://reviews.apache.org/r/9669/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

Sure. I will update the patch again.

Thanks,
Vasanth
On Mon, Mar 11, 2013 at 11:05 AM, Jarek Cecho <[EMAIL PROTECTED]> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
>
> Hi Vasanth,
> would you mind rebasing your changes with current changes in head of the sqoop2 branch? I'll be happy to help or to take it from here if you're not interested any more.
>
> Jarcec
>
>
> - Jarek
>
> On February 28th, 2013, 3:04 a.m., vasanthkumar wrote:
>   Review request for Sqoop.
> By vasanthkumar.
>
> *Updated Feb. 28, 2013, 3:04 a.m.*
> Description
>
> Move string constants from FormDisplayer to resource file
>
>   Testing
>
> Done
>
>   *Bugs: * SQOOP-887 <https://issues.apache.org/jira/browse/SQOOP-887>
> Diffs
>
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
>    (af325d5)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
>    (c2464d2)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
>    (31de8dc)
>    - client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
>    (0d67133)
>    - client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
>    (4d0442f)
>    - client/src/main/resources/client-resource.properties (58cfe55)
>
> View Diff <https://reviews.apache.org/r/9669/diff/>
>

--
Regards
Vasanth kumar RJ

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/
-----------------------------------------------------------

(Updated March 11, 2013, 12:33 p.m.)
Review request for Sqoop.
Changes
-------

Patch updated based on new commits

Thanks,
Vasanth
Description
-------

Move string constants from FormDisplayer to resource file
This addresses bug SQOOP-887.
    https://issues.apache.org/jira/browse/SQOOP-887
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
  client/src/main/resources/client-resource.properties c3a22bb

Diff: https://reviews.apache.org/r/9669/diff/
Testing
-------

Done
Thanks,

vasanthkumar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/#review17956
-----------------------------------------------------------
Hi Vasanth,
thank you very much for reworking this patch. Would you mind putting the string resource constants into the client's Constant class?

Jarcec

- Jarek Cecho
On March 11, 2013, 12:33 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
> -----------------------------------------------------------
>
> (Updated March 11, 2013, 12:33 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Move string constants from FormDisplayer to resource file
>
>
> This addresses bug SQOOP-887.
>     https://issues.apache.org/jira/browse/SQOOP-887
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
>   client/src/main/resources/client-resource.properties c3a22bb
>
> Diff: https://reviews.apache.org/r/9669/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/
-----------------------------------------------------------

(Updated March 15, 2013, 6:12 a.m.)
Review request for Sqoop.
Changes
-------

Hi Jarek,

Thank you for your review comments. Moved resource constants into client's constant class and patch updated.

vasanth
Description
-------

Move string constants from FormDisplayer to resource file
This addresses bug SQOOP-887.
    https://issues.apache.org/jira/browse/SQOOP-887
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java ae3f994
  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
  client/src/main/resources/client-resource.properties c3a22bb

Diff: https://reviews.apache.org/r/9669/diff/
Testing
-------

Done
Thanks,

vasanthkumar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/#review17987
-----------------------------------------------------------
Hi Vasanth,
thank you for your quick feedback. I do have one final nit and I'm ready to commit it!
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
<https://reviews.apache.org/r/9669/#comment38005>

    Can we rename the function to just "print" to match the others?
Jarcec

- Jarek Cecho
On March 15, 2013, 6:12 a.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9669/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 6:12 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Move string constants from FormDisplayer to resource file
>
>
> This addresses bug SQOOP-887.
>     https://issues.apache.org/jira/browse/SQOOP-887
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java ae3f994
>   client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
>   client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
>   client/src/main/resources/client-resource.properties c3a22bb
>
> Diff: https://reviews.apache.org/r/9669/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9669/
-----------------------------------------------------------

(Updated March 15, 2013, 7:47 p.m.)
Review request for Sqoop.
Changes
-------

Hi Jarek,

Thanks for your review comments. Implemented your suggestions.
vasanth
Description
-------

Move string constants from FormDisplayer to resource file
This addresses bug SQOOP-887.
    https://issues.apache.org/jira/browse/SQOOP-887
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/core/Constants.java ae3f994
  client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java 8c133f2
  client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java abd9643
  client/src/main/resources/client-resource.properties c3a22bb

Diff: https://reviews.apache.org/r/9669/diff/
Testing
-------

Done
Thanks,

vasanthkumar