-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9069/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've extended Executor class to provide ability to set autoCommit and explicitly set it to false in export loader.
This addresses bug SQOOP-843.
    https://issues.apache.org/jira/browse/SQOOP-843
Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 2dba8af
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 31dbcea

Diff: https://reviews.apache.org/r/9069/diff/
Testing
-------

Unit tests seems to be passing and I've tested the export on real cluster.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9069/#review15620
-----------------------------------------------------------

Ship it!
Ship It!

- Venkat Ranganathan
On Jan. 23, 2013, 5:38 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9069/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 5:38 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended Executor class to provide ability to set autoCommit and explicitly set it to false in export loader.
>
>
> This addresses bug SQOOP-843.
>     https://issues.apache.org/jira/browse/SQOOP-843
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 2dba8af
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 31dbcea
>
> Diff: https://reviews.apache.org/r/9069/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested the export on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9069/#review15896
-----------------------------------------------------------

Ship it!
Ship It!

- Cheolsoo Park
On Jan. 23, 2013, 5:38 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9069/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 5:38 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've extended Executor class to provide ability to set autoCommit and explicitly set it to false in export loader.
>
>
> This addresses bug SQOOP-843.
>     https://issues.apache.org/jira/browse/SQOOP-843
>
>
> Diffs
> -----
>
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java 2dba8af
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 31dbcea
>
> Diff: https://reviews.apache.org/r/9069/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing and I've tested the export on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>