Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1972 ElasticSearchSink now allows the id of the document to be provided by a custom class


Copy link to this message
-
Review Request: FLUME-1972 ElasticSearchSink now allows the id of the document to be provided by a custom class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10380/
-----------------------------------------------------------

Review request for Flume and Hari Shreedharan.
Description
-------

Elasticsearch allows clients to specify the id of the newly added document - and will generate one by default if none is supplied. If the user knows that the incoming event has a unique id then that id can be used as the elasticsearch document id. This change enhances the ElasticSearchSink to allow users to provide a custom class to decide what the id should be.
This addresses bug FLUME-1972.
    https://issues.apache.org/jira/browse/FLUME-1972
Diffs
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 693c0d7
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchIdProvider.java PRE-CREATION
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchNullIdProvider.java PRE-CREATION
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSink.java 1b3db14
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkConstants.java 7f75e22
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java 2edacdc
  flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java 94b95b1

Diff: https://reviews.apache.org/r/10380/diff/
Testing
-------

All unit tests and integration tests pass. A snapshot using commit 5b9d31f1ad228 and the patch for flume-1972 has passed our internal integration tests using customisations.
Thanks,

Edward Sargisson

+
Israel Ekpo 2013-04-10, 11:04
+
Edward Sargisson 2013-04-10, 17:00
+
Israel Ekpo 2013-04-10, 18:07
+
Israel Ekpo 2013-04-11, 10:10
+
Edward Sargisson 2013-04-11, 19:02
+
Edward Sargisson 2013-04-18, 23:56
+
Israel Ekpo 2013-04-11, 20:37
+
Israel Ekpo 2013-04-11, 20:54
+
Israel Ekpo 2013-04-11, 20:56