Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request 12889: AsyncHbase Sink bugfix plus tests errors on Windows


+
Roshan Naik 2013-07-24, 03:01
Copy link to this message
-
Re: Review Request 12889: AsyncHbase Sink bugfix plus tests errors on Windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12889/#review23741
-----------------------------------------------------------

Ship it!
Good catch. Thanks, Roshan

- Alexander Alten-Lorenz
On July 24, 2013, 3:01 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12889/
> -----------------------------------------------------------
>
> (Updated July 24, 2013, 3:01 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2134
>     https://issues.apache.org/jira/browse/FLUME-2134
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> 1) The Async HBase sink uses conf.get("hbase.zookeeper.quorum") to get the zookeeper quorum info... which on windows is only returning "localhost". HBase folks advised the use of  ZKConfig.getZKQuorumServersString(conf) instead. I confirmed it returns the right value  "localhost:port#" on both Windows and Linux.
>
> 2) Setup code in Async HBase Sink tests are simplified to use testUtility provided by HBase to spin up a HBase cluster. The Temporary directory creation in the old code caused problems when used by HBase, if the directory name had a space in it.
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java 7020fcd
>   flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java 7ddfdae
>
> Diff: https://reviews.apache.org/r/12889/diff/
>
>
> Testing
> -------
>
> Tests pass both on Linux and Windows.
>
>
> Thanks,
>
> Roshan Naik
>
>

+
Alexander Alten-Lorenz 2013-07-24, 07:36
+
Alexander Alten-Lorenz 2013-07-24, 07:36