-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

Review request for Sqoop.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
  client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/#review14882
-----------------------------------------------------------
Works fine. I think requires Suppresswarning annotation for serial. At line 67, "verbose" value can be used from constants.
Thanks.
Vasanth kumar

- vasanthkumar
On Dec. 23, 2012, 10:42 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8751/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2012, 10:42 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've provided "show option" command that allows user to show client options.
>
>
> This addresses bug SQOOP-750.
>     https://issues.apache.org/jira/browse/SQOOP-750
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8751/diff/
>
>
> Testing
> -------
>
> Tested on real cluster, no new unit tests provided.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

(Updated Dec. 25, 2012, 6:23 a.m.)
Review request for Sqoop.
Changes
-------

I've changed the verbose text on line 67 to Constant as Vasant has recommended in the review.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

(Updated Dec. 25, 2012, 6:23 a.m.)
Review request for Sqoop.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

(Updated Dec. 27, 2012, 5:30 a.m.)
Review request for Sqoop.
Changes
-------

Adding missing ShowOptionFunction file.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
  client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/#review14943
-----------------------------------------------------------

client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
<https://reviews.apache.org/r/8751/#comment32010>

    Your change to use constant seems to be lost in this patch.
- Bilung Lee
On Dec. 27, 2012, 5:30 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8751/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2012, 5:30 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've provided "show option" command that allows user to show client options.
>
>
> This addresses bug SQOOP-750.
>     https://issues.apache.org/jira/browse/SQOOP-750
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8751/diff/
>
>
> Testing
> -------
>
> Tested on real cluster, no new unit tests provided.
>
>
> Thanks,
>
> Jarek Cecho
>
>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

(Updated Dec. 28, 2012, 8:11 a.m.)
Review request for Sqoop.
Changes
-------

Thanks Bilung for your patience with this patch.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs (updated)
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
  client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/
-----------------------------------------------------------

(Updated Dec. 28, 2012, 8:12 a.m.)
Review request for Sqoop.
Description
-------

I've provided "show option" command that allows user to show client options.
This addresses bug SQOOP-750.
    https://issues.apache.org/jira/browse/SQOOP-750
Diffs
-----

  client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
  client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION

Diff: https://reviews.apache.org/r/8751/diff/
Testing
-------

Tested on real cluster, no new unit tests provided.
Thanks,

Jarek Cecho

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8751/#review14968
-----------------------------------------------------------

Ship it!
Ship It!

- Bilung Lee
On Dec. 28, 2012, 8:12 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8751/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2012, 8:12 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've provided "show option" command that allows user to show client options.
>
>
> This addresses bug SQOOP-750.
>     https://issues.apache.org/jira/browse/SQOOP-750
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 359add94363a575036999c90fe5088b003064844
>   client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8751/diff/
>
>
> Testing
> -------
>
> Tested on real cluster, no new unit tests provided.
>
>
> Thanks,
>
> Jarek Cecho
>
>