Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request: HIVE-4549: JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM


Copy link to this message
-
Re: Review Request: HIVE-4549: JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM


> On June 7, 2013, 5:52 p.m., Shreepadma Venugopalan wrote:
> > Ship It!

LGTM! It will break applications that assert on TABLE_SCHEMA, but then those asserts are incorrect in the first place.
- Shreepadma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11706/#review21586
-----------------------------------------------------------
On June 7, 2013, 2:10 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11706/
> -----------------------------------------------------------
>
> (Updated June 7, 2013, 2:10 a.m.)
>
>
> Review request for hive.
>
>
> Description
> -------
>
> JDBC compliance change TABLE_SCHEMA to TABLE_SCHEM for getTables() and getSchemas().
>
> The GetTablesOperation at this point generates a resultset that alings with ODBC SQLTables() and missing columns TYPE_CAT, TYPE_SCHEM, TYPE_NAME, SELF_REFERENCING_COL_NAME and REF_GENERATION per JDBC spec. On the other hand GetColumnsOperation matches JDBC but adds some extra columns for ODBC. I will log a separate ticket to handle the metadata request differences between JDBC and ODBC.
>
>
> This addresses bug HIVE-4549.
>     https://issues.apache.org/jira/browse/HIVE-4549
>
>
> Diffs
> -----
>
>   jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 35c8e8f
>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java 6970f35
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java df8b5b3
>
> Diff: https://reviews.apache.org/r/11706/diff/
>
>
> Testing
> -------
>
> Updated testcases in TestJdbcDriver2
>
>
> Thanks,
>
> Prasad Mujumdar
>
>