Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17483: Support for hbase filters for composite keys


Copy link to this message
-
Re: Review Request 17483: Support for hbase filters for composite keys

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17483/#review33329
-----------------------------------------------------------

hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
<https://reviews.apache.org/r/17483/#comment62770>

    OK I see it now. All composite keys must extends the class HBaseCompositeKey, correct?
    
    If that is true, I think we can make compositeKeyObj of type HBaseCompositeKey and then cast the result from newInstance as HBaseCompositeKey and call getFilter directly.
    
    Perhaps not all composite keys are HBaseCompositeKey and thus reflection is needed?
- Brock Noland
On Jan. 29, 2014, 6:04 a.m., Swarnim Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17483/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 6:04 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6290
>     https://issues.apache.org/jira/browse/HIVE-6290
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support to be able to provide scan filter for hive/hbase integration for composite keys.
>
>
> Diffs
> -----
>
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java 5008f15
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 899ccce
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 704fcb9
>   hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestCompositeKey.java 13c344b
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java d39ee2e
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java 5f1329c
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java e50026b
>
> Diff: https://reviews.apache.org/r/17483/diff/
>
>
> Testing
> -------
>
> Tested using locally created data and debug logs that the filter gets applied on the scan.
>
>
> Thanks,
>
> Swarnim Kulkarni
>
>