Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17737: Add DECIMAL support to vectorized group by operator


Copy link to this message
-
Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17737/#review33964

common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java
<https://reviews.apache.org/r/17737/#comment63819>

    Tab characters and indentation need fix.

common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java
<https://reviews.apache.org/r/17737/#comment63820>

    Indentation needs to be fixed.

ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt
<https://reviews.apache.org/r/17737/#comment63849>

    Should we initialize isNull to true? It seems it will always be false otherwise.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java
<https://reviews.apache.org/r/17737/#comment64067>

    Please declare a constant for this number.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/17737/#comment64068>

    HIVE-6333 modifies this method to return decimal type along with precision and scale e.g. decimal(5,3).
- Jitendra Pandey
On Feb. 5, 2014, 11:04 a.m., Remus Rusanu wrote: