Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17632: HDFS ZeroCopy Shims for Hive


Copy link to this message
-
Re: Review Request 17632: HDFS ZeroCopy Shims for Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17632/#review33571
-----------------------------------------------------------

shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
<https://reviews.apache.org/r/17632/#comment63104>

    this comment should probably move 3 lines down.

shims/0.23/src/main/java/org/apache/hadoop/hive/shims/ZeroCopyShims.java
<https://reviews.apache.org/r/17632/#comment63105>

    nit: as a const this would look better as CHECK_SUM, NO_CHECK_SUM.
- Gunther Hagleitner
On Feb. 4, 2014, 6:11 a.m., Gopal V wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17632/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2014, 6:11 a.m.)
>
>
> Review request for hive, Gunther Hagleitner and Owen O'Malley.
>
>
> Bugs: HIVE-6346
>     https://issues.apache.org/jira/browse/HIVE-6346
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Hive Shims for ZeroCopy FS read and Direct ByteBuffer decompression (hadoop/branch-2 changes)
>
>
> Diffs
> -----
>
>   pom.xml 0af4b08
>   shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java ec1f18e
>   shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java d0ff7d4
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 54c38ee
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/ZeroCopyShims.java PRE-CREATION
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 2b3c6c1
>
> Diff: https://reviews.apache.org/r/17632/diff/
>
>
> Testing
> -------
>
> TPC-DS queries.
>
>
> Thanks,
>
> Gopal V
>
>