Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18025: Implement vectorized support for COALESCE conditional expression


Copy link to this message
-
Re: Review Request 18025: Implement vectorized support for COALESCE conditional expression

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18025/#review34370

ql/src/test/queries/clientpositive/vector_coalesce.q
<https://reviews.apache.org/r/18025/#comment64447>

    Can you do one with > 3 arguments too? Will that vectorize?

ql/src/test/queries/clientpositive/vector_coalesce.q
<https://reviews.apache.org/r/18025/#comment64450>

    Please also test for smallint and timestamp.

ql/src/test/queries/clientpositive/vector_coalesce.q
<https://reviews.apache.org/r/18025/#comment64451>

    Please also test for expressions as arguments, not just columns.

ql/src/test/queries/clientpositive/vector_coalesce.q
<https://reviews.apache.org/r/18025/#comment64448>

    It is not unusual to use COALESCE like this:
    
    COALESCE(col1, ..., colK, 0)
    
    So if arguments 1..K are NULL, the default value is the constant at the end, 0 in this case. Could you please make that work in this patch, or open a separate JIRA to do it later?
- Eric Hanson
On Feb. 12, 2014, 7 p.m., Jitendra Pandey wrote: