Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 18492: HIVE-6473: Allow writing HFiles via HBaseStorageHandler table


Copy link to this message
-
Re: Review Request 18492: HIVE-6473: Allow writing HFiles via HBaseStorageHandler table
Swarnim Kulkarni 2014-03-07, 21:01

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18492/#review36574

hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
<https://reviews.apache.org/r/18492/#comment67579>

    Nit: Don't need the else here.

hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
<https://reviews.apache.org/r/18492/#comment67580>

    Do we have bugs logged for this or it would be covered in future revisions on the same patch?

hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java
<https://reviews.apache.org/r/18492/#comment67581>

    Nit: Log.error would be more apt here.
- Swarnim Kulkarni
On Feb. 26, 2014, 12:07 a.m., nick dimiduk wrote: