Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 19149: Stand alone metastore fails to start if new transaction values not defined in config


Copy link to this message
-
Re: Review Request 19149: Stand alone metastore fails to start if new transaction values not defined in config
Ashutosh Chauhan 2014-03-12, 20:21

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19149/#review36974

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/19149/#comment68194>

    Good we are deleting this. Previously I wondered why we need this when we gonna write to same metastore.

metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java
<https://reviews.apache.org/r/19149/#comment68195>

    Do we need to synchronize this method?

metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java
<https://reviews.apache.org/r/19149/#comment68192>

    Doing new HiveConf(), should be avoided if possible because:
    * Its an expensive operation, perf wise.
    * Other conf object in memory may have different values because of set commands.
    If you aren't able to get hold of hiveconf object, probably we need to make changes upstream to pass it all the way down here.
    

metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java
<https://reviews.apache.org/r/19149/#comment68193>

    You created prop object but didn't make use of it. Don't you want to use that prop here, instead of new Properties?
- Ashutosh Chauhan
On March 12, 2014, 7:20 p.m., Alan Gates wrote: