Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 17769: Generate vectorized plan for decimal expressions.


Copy link to this message
-
Re: Review Request 17769: Generate vectorized plan for decimal expressions.

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17769/#review34088

Ship it!
The functionality looks good. Please address the minor issues about the comments that I pointed out. No need for me to do another review.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/17769/#comment64058>

    there -> their

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/17769/#comment64060>

    Please add comment before method explaining what it does.

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
<https://reviews.apache.org/r/17769/#comment64059>

    loose -> lose
- Eric Hanson
On Feb. 8, 2014, 6:15 a.m., Jitendra Pandey wrote: