Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 17441: Adds concept of root role in Hive.


Copy link to this message
-
Re: Review Request 17441: Adds concept of root role in Hive.
Brock Noland 2014-01-28, 21:32

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17441/#review33048
-----------------------------------------------------------

itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAdminUser.java
<https://reviews.apache.org/r/17441/#comment62262>

    Still tabs here

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62263>

    This should be statically synchronized, no?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62264>

    This debug message doesn't make sense to me. Can you improve it?

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62268>

    Aren't we doing this:
    
    http://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#isAssignableFrom(java.lang.Class)

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62265>

    This should have a log message

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62267>

    String x = hiveConf.getVar(ConfVars.X, "").trim();
    if(x.isEmpty() {
    
    }
    
    is cleaner and simpler

metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/17441/#comment62266>

    We should be using guava Splitter here and each user should be trimmed (which splitter supports)
- Brock Noland
On Jan. 28, 2014, 9:17 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17441/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 9:17 p.m.)
>
>
> Review request for hive and Thejas Nair.
>
>
> Bugs: HIVE-5959
>     https://issues.apache.org/jira/browse/HIVE-5959
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Adds concept of root role in Hive.
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 84ee78f
>   conf/hive-default.xml.template 66d22f9
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAdminUser.java PRE-CREATION
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 58f9957
>
> Diff: https://reviews.apache.org/r/17441/diff/
>
>
> Testing
> -------
>
> New junit test added.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>