Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 23319: HIVE-7342 - support hiveserver2, metastore specific config files


Copy link to this message
-
Re: Review Request 23319: HIVE-7342 - support hiveserver2, metastore specific config files

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23319/

(Updated July 10, 2014, 9:37 p.m.)
Review request for hive.
Changes

With earlier patch hivemetastore-site.xml would take precedence over hiveserver2-site.xml if embedded metastore is used with hiveserver2, as metastore-site.xml was getting added later.
With this change HiveConf initialization itself would check if embedded metastore is used and load the hivemetastore-site.xml. This way the order of adding the resources to the Configuration always remains the same.

Patch also adds tests for both embedded and remote metastore mode.

The order of predendence (later one takes precedence) :
hive-site.xml -> hivemetastore-site.xml -> hiveserver2-site.xml -> HiveConf.ConfVars set through system properties (same as ones set through -hiveconf cmdline params)
Bugs: HIVE-7342
    https://issues.apache.org/jira/browse/HIVE-7342
Repository: hive-git
Description

See jira
Diffs (updated)

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9
  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java PRE-CREATION
  data/conf/hive-site.xml 1c9c598
  data/conf/hivemetastore-site.xml PRE-CREATION
  data/conf/hiveserver2-site.xml PRE-CREATION
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestServerSpecificConfig.java PRE-CREATION
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java acef599
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 664dccd
  service/src/java/org/apache/hive/service/cli/thrift/EmbeddedThriftBinaryCLIService.java 62b1d9c
  service/src/java/org/apache/hive/service/server/HiveServer2.java e7ed267

Diff: https://reviews.apache.org/r/23319/diff/
Testing

New tests added
Thanks,

Thejas Nair