Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 17661: HIVE-6327: A few mathematic functions don't take decimal input


Copy link to this message
-
Review Request 17661: HIVE-6327: A few mathematic functions don't take decimal input
Xuefu Zhang 2014-02-03, 14:26

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17661/
-----------------------------------------------------------

Review request for hive.
Bugs: HIVE-6327
    https://issues.apache.org/jira/browse/HIVE-6327
Repository: hive-git
Description
-------

Added methods for those UDFs such that decimal type can be accepted and evaluated.
Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAcos.java 4e2b50e
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAsin.java f7adce4
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java fb861a5
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCos.java d9ce12d
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFExp.java 9c8c836
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java 883b541
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java a90e622
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 1cc70a4
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog2.java e3f2026
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMath.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java 47e18ee
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java e714c17
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSqrt.java 4eefc8c
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java 8ebd727
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFMath.java PRE-CREATION

Diff: https://reviews.apache.org/r/17661/diff/
Testing
-------

New unit test cases are added to test all the UDFs regarding decimal input.
Thanks,

Xuefu Zhang