Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 18566: Queries fail to Vectorize.


Copy link to this message
-
Re: Review Request 18566: Queries fail to Vectorize.

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18566/#review35682
Looks good.

Please add unit tests to exercise the code you changed, or if this code is already covered by other tests, please explain in comments on the JIRA.

common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java
<https://reviews.apache.org/r/18566/#comment66370>

    Please add comment saying the purpose of this method
- Eric Hanson
On Feb. 27, 2014, 6:43 a.m., Jitendra Pandey wrote: