Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 23797: HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats


Copy link to this message
-
Re: Review Request 23797: HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23797/#review50848

hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoaderComplexSchema.java
<https://reviews.apache.org/r/23797/#comment88721>

    According to the JUnit docs a "failing assumption in a @Before or @BeforeClass method will have the same effect as a failing assumption in each @Test method of the class." I think it's better to explicitly add this to each test method.

hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java
<https://reviews.apache.org/r/23797/#comment88719>

    Do all of these tests fail for Parquet format or only a subset of them?

hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatStorerMulti.java
<https://reviews.apache.org/r/23797/#comment88720>

    Is it possible to static import this (e.g. like assertTrue)?

ql/src/test/org/apache/hadoop/hive/ql/io/StorageFormats.java
<https://reviews.apache.org/r/23797/#comment88716>

    The javadoc doesn't agree with the actual return type of this method. People who aren't familiar with JUnit and/or aren't aquainted with the requirements of the Parameterized API aren't going to understand why this method doesn't return List<String>. Can you please add a note explaining this and also consider changing the name of the method in order to reduce the chance of confusion?
- Carl Steinbach
On July 31, 2014, 1:38 a.m., David Chen wrote: