-Re: Review Request 23797: HIVE-7420: Parameterize tests for HCatalog Pig interfaces for testing against all storage formats.
This is an automatically generated e-mail. To reply, visit:
According to the JUnit docs a "failing assumption in a @Before or @BeforeClass method will have the same effect as a failing assumption in each @Test method of the class." I think it's better to explicitly add this to each test method.
Do all of these tests fail for Parquet format or only a subset of them?
Is it possible to static import this (e.g. like assertTrue)?
The javadoc doesn't agree with the actual return type of this method. People who aren't familiar with JUnit and/or aren't aquainted with the requirements of the Parameterized API aren't going to understand why this method doesn't return List<String>. Can you please add a note explaining this and also consider changing the name of the method in order to reduce the chance of confusion?
- Carl Steinbach
On July 31, 2014, 1:38 a.m., David Chen wrote: